Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Destination bigquery 1s1t: handle erroneous cdc deletion record #29106

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Aug 4, 2023

this should never really happen, but deal with the case where _ab_cdc_deleted_at is a non-scalar value. We want to delete the record in this case.

(this behavior has flip-flopped a few times when we were moving the cdc delete logic to/from the final table, and the test case is currently wrong)

bigquery's JSON_VALUE function returns null if the value is an object or array, so switch to an explicit json_type(json_query()) call. Also fix the test input data.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@edgao edgao changed the title Destination bigquery 1s1t: handle erroneous cdc deletion record 🐛 Destination bigquery 1s1t: handle erroneous cdc deletion record Aug 4, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 4, 2023
@edgao edgao marked this pull request as ready for review August 4, 2023 20:29
@edgao edgao requested a review from a team as a code owner August 4, 2023 20:29
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥞

@edgao edgao enabled auto-merge (squash) August 4, 2023 20:33
@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery test report (commit 1834a50b8c) - ✅

⏲️ Total pipeline duration: 33mn56s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build destination-bigquery docker image for platform linux/x86_64
Build airbyte/normalization:dev
./gradlew :airbyte-integrations:connectors:destination-bigquery:integrationTest

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

@edgao edgao merged commit 4602954 into master Aug 4, 2023
@edgao edgao deleted the edgao/1s1t/cdc_fix branch August 4, 2023 21:05
@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery test report (commit 7662a70c3c) - ❌

⏲️ Total pipeline duration: 29mn45s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build destination-bigquery docker image for platform linux/x86_64
Build airbyte/normalization:dev
./gradlew :airbyte-integrations:connectors:destination-bigquery:integrationTest

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/bigquery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants