-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Source FreshServices : Migrate Python CDK to Low-code CDK #29126
✨Source FreshServices : Migrate Python CDK to Low-code CDK #29126
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your contribution! This overall looks great! I have a few small changes for you!
airbyte-integrations/connectors/source-freshservice/metadata.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-freshservice/metadata.yaml
Outdated
Show resolved
Hide resolved
@archangelic done changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some changes to get acceptance tests working!
airbyte-integrations/connectors/source-freshservice/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-freshservice/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-freshservice/source_freshservice/manifest.yaml
Show resolved
Hide resolved
Co-authored-by: Mal Hancock <mhancock@archangelic.space>
Co-authored-by: Mal Hancock <mhancock@archangelic.space>
Co-authored-by: Mal Hancock <mhancock@archangelic.space>
@archangelic anything else |
Everything looks good! Going to merge this! |
Co-authored-by: Mal Hancock <mhancock@archangelic.space>
…#29126) Co-authored-by: Mal Hancock <mhancock@archangelic.space>
What
Migrating Source freshservices to Low-Code CDK
Closes #28992
How
Developed using (Configuration Based Source) low-code CDK
Recommended reading order
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
Yes, there are breaking changes due to Changes to Stream Schema
At many places previous data type were wrong and added some new properties in schema as per response from API
Test
Acceptance Test
Migrate Connector : Source FreshServices