-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connectors-ci: fix pip install error #29156
connectors-ci: fix pip install error #29156
Conversation
source-intercom test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-intercom/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ❌ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-intercom test
source-openweather test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-openweather/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-openweather docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-openweather test
Manual testingI triggered a test pipeline for |
This reverts commit 3690025.
What
Closes #29147
Fixes two problems:
with_exec("pip", "install", ...)
was called too early: it was evaluated during theget_file_contents
function, this function raised an unrelated errors because it first executed the lazywith_exec(["pip", "install"])
before processing the file contentsetup.py
orrequirements.txt
usingget_file_contents
raises a dagger exception that we correctly handled but Dagger will still consider this as a failure on their UI when the file does not exist.How
setup.py
orrequirements.txt
exist with thecheck_path_in_workdir
function. This function does not raise a Dagger exception if the file does not exist.setup.py
orrequirements.txt
exist before appendingwith_exec(["pip", "install", ...])
to the container: it solved the early raise of pip install error that led to sentry error capture