Avro parser: return Decimal fields as strings #29182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girarda
commented
Aug 7, 2023
| @@ -157,5 +157,11 @@ def _to_output_value(avro_format: AvroFormat, record_type: Mapping[str, Any], re | |||
| return record_value | |||
| if record_type.get("logicalType") == "uuid": | |||
| return uuid.UUID(bytes=record_value) | |||
| elif record_type.get("logicalType") == "decimal": | |||
| return str(record_value) | |||
There was a problem hiding this comment.
girarda
commented
Aug 7, 2023
| @@ -398,7 +398,7 @@ | |||
| "drummer": "George Daniel", | |||
| }, | |||
| "col_fixed": "\x12\x34\x56\x78", | |||
| "col_decimal": 1234.56789, | |||
| "col_decimal": "1234.56789", | |||
There was a problem hiding this comment.
decimals should always be read as strings
girarda
commented
Aug 7, 2023
| return str(record_value) | ||
| return record_value | ||
| if record_type.get("logicalType") == "uuid": | ||
| return uuid.UUID(bytes=record_value) | ||
| elif record_type.get("logicalType") == "decimal": | ||
| return str(record_value) | ||
| elif record_type.get("logicalType") == "date": |
There was a problem hiding this comment.
explicitly convert the output to the format we want instead of returning a date/datetime
girarda
changed the title
brianjlai
approved these changes
Aug 8, 2023
| double_as_string: bool = Field( | ||
| title="Convert Double Fields to Strings", | ||
| description="Whether to convert double fields to strings. There is a loss of precision when converting decimals to floats, so this is recommended.", | ||
| default=True, |
There was a problem hiding this comment.
And to confirm. For legacy S3 connectors, the adapter will by default set this to False if I understand correct.
There was a problem hiding this comment.
yes, created an issue #29225
clnoll
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
double_as_stringto make it clearer that it is affecting double fields, not decimalsRecommended reading order
airbyte-cdk/python/airbyte_cdk/sources/file_based/config/avro_format.pyairbyte-cdk/python/airbyte_cdk/sources/file_based/file_types/avro_parser.pyairbyte-cdk/python/unit_tests/sources/file_based/file_types/test_avro_parser.pyairbyte-cdk/python/unit_tests/sources/file_based/scenarios/avro_scenarios.pyairbyte-cdk/python/unit_tests/sources/file_based/test_scenarios.pyairbyte-cdk/python/unit_tests/sources/file_based/scenarios/csv_scenarios.py