Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging destinations: Simplify default namespace handling #29188

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Aug 7, 2023

Instead of doing namespace==null checks everywhere, just set namespace=defaultNamespace at the earliest possible moment:

  • Mutate the catalog at the connector entrypoint (i.e. getConsumer)
  • Mutate messages when we deserialize them

At some point we should clean up all the existing null checks, but I think this is sufficient to unblock interesting 1s1t work.

(leaving redshift untouched for now, but most likely will do the same thing when we start doing redshift 1s1t. Leaving snowflake s3/gcs untouched because we want to deprecate them anyway)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 7, 2023
@edgao edgao marked this pull request as ready for review August 7, 2023 21:10
@edgao edgao requested review from a team as code owners August 7, 2023 21:10
@edgao edgao requested review from davinchia and tryangul August 7, 2023 21:10
Copy link
Contributor

@tryangul tryangul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octavia-squidington-iii
Copy link
Collaborator

destination-snowflake test report (commit c88c0dee02) - ✅

⏲️ Total pipeline duration: 43mn54s

Step Result
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build destination-snowflake docker image for platform linux/x86_64
Build airbyte/normalization-snowflake:dev
./gradlew :airbyte-integrations:connectors:destination-snowflake:integrationTest

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

@edgao edgao enabled auto-merge (squash) August 7, 2023 22:02
@octavia-squidington-iii
Copy link
Collaborator

destination-redshift test report (commit c88c0dee02) - ❌

⏲️ Total pipeline duration: 22mn00s

Step Result
Validate airbyte-integrations/connectors/destination-redshift/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build destination-redshift docker image for platform linux/x86_64
Build airbyte/normalization-redshift:dev
./gradlew :airbyte-integrations:connectors:destination-redshift:integrationTest

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-redshift test

@octavia-squidington-iii
Copy link
Collaborator

destination-redshift test report (commit 8e934219f0) - ✅

⏲️ Total pipeline duration: 34mn07s

Step Result
Validate airbyte-integrations/connectors/destination-redshift/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build destination-redshift docker image for platform linux/x86_64
Build airbyte/normalization-redshift:dev
./gradlew :airbyte-integrations:connectors:destination-redshift:integrationTest

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-redshift test

@octavia-squidington-iii
Copy link
Collaborator

destination-snowflake test report (commit 8e934219f0) - ✅

⏲️ Total pipeline duration: 41mn40s

Step Result
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build destination-snowflake docker image for platform linux/x86_64
Build airbyte/normalization-snowflake:dev
./gradlew :airbyte-integrations:connectors:destination-snowflake:integrationTest

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

@edgao edgao merged commit 38530ee into master Aug 9, 2023
@edgao edgao deleted the edgao/default_namespace branch August 9, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants