Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Amazon Ads: Add new tactic support for sponsored_display_report_stream #29212

Merged

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Aug 8, 2023

What

For sponsored_display_report_stream we sync only T00020 tactic, so we can miss campaigns which use T00030 tactic.
https://github.com/airbytehq/oncall/issues/2488

How

Add T00030 tactic support for sponsored_display_report_stream

🚨 User Impact 🚨

No

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii
Copy link
Collaborator

source-amazon-ads test report (commit 2bc1a69f74) - ✅

⏲️ Total pipeline duration: 04mn25s

Step Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-amazon-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, please consider the comments bellow.

@octavia-squidington-iii
Copy link
Collaborator

source-amazon-ads test report (commit 44e5278a27) - ✅

⏲️ Total pipeline duration: 04mn00s

Step Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-amazon-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

@lazebnyi lazebnyi merged commit 21871d6 into master Aug 10, 2023
@lazebnyi lazebnyi deleted the lazebnyi/2488-source-amazon-ads-add-new-tactic-support branch August 10, 2023 11:33
@sentry-io
Copy link

sentry-io bot commented Aug 16, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ source_amazon_ads.streams.report_streams.report_streams.ReportInitFailure: Unexpected HTTP status code 500 when registering campaigns, SponsoredDisplayReportStream for 2721... /airbyte/integration_code/source_amazon_ads/str... View Issue
  • ‼️ source_amazon_ads.streams.report_streams.report_streams.ReportInitFailure: Unexpected HTTP status code 500 when registering productAds, SponsoredDisplayReportStream for 399... /airbyte/integration_code/source_amazon_ads/str... View Issue

Did you find this useful? React with a 👍 or 👎

harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
…t_stream (airbytehq#29212)

* Add source amazon ads T00030 tactic for sponsored_display_report_stream

* Fix code style and unit test

* Rename report_infos variable to report_info_list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Amazon Ads: Sponsored Display Report Audiences targeting (T00030)
4 participants