Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Hubspot: set threadId to string in engagements stream #29248

Conversation

arsenlosenko
Copy link
Contributor

What

Resolve issue describe here:
#28236

How

Specified threadId property in engagements metadata to string, as this is the correct type which is returned during reading of this stream.

@arsenlosenko arsenlosenko self-assigned this Aug 9, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot labels Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@arsenlosenko arsenlosenko marked this pull request as ready for review August 9, 2023 11:54
@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit d518e461bf) - ❌

⏲️ Total pipeline duration: 11mn48s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit fe3f21d906) - ❌

⏲️ Total pipeline duration: 11mn10s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit fb0df2077d) - ✅

⏲️ Total pipeline duration: 11mn42s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit 39445597a3) - ✅

⏲️ Total pipeline duration: 11mn49s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit b1bdb40f1d) - ✅

⏲️ Total pipeline duration: 11mn13s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

@arsenlosenko arsenlosenko merged commit b78ad4e into master Aug 11, 2023
@arsenlosenko arsenlosenko deleted the arsenlosenko/28236-source-hubspot-update-engagements-metadata branch August 11, 2023 11:44
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
…bytehq#29248)

* Source Hubspot: set  to string in  stream

* Update changelog

* Update expected records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Hubspot: Engagement stream on Bigquery(denormalized) - field: metadata incompatible type
4 participants