-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Zendesk Support: update descriptions in spec #29256
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
source-zendesk-support test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-zendesk-support docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-zendesk-support test
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/spec.json
Outdated
Show resolved
Hide resolved
…zendesk_support/spec.json Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
source-zendesk-support test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-zendesk-support docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-zendesk-support test
* update zendesk support spec descriptions * update changelog * Update airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/spec.json Co-authored-by: Sherif A. Nada <snadalive@gmail.com> --------- Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
What
Small update to the Zendesk Support spec file
How
Added recommended authentication methods for Cloud/OSS to auth description
Added some links to guides for OSS OAuth credentials
Couple of minor clarity/grammar edits