Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Zendesk Support: update descriptions in spec #29256

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Conversation

ChristoGrab
Copy link
Contributor

What

Small update to the Zendesk Support spec file

How

Added recommended authentication methods for Cloud/OSS to auth description
Added some links to guides for OSS OAuth credentials
Couple of minor clarity/grammar edits

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii
Copy link
Collaborator

source-zendesk-support test report (commit 0f6faaeb5c) - ✅

⏲️ Total pipeline duration: 12mn18s

Step Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-zendesk-support docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@ChristoGrab ChristoGrab requested a review from sherifnada August 9, 2023 16:10
…zendesk_support/spec.json

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@octavia-squidington-iii
Copy link
Collaborator

source-zendesk-support test report (commit aebb79976a) - ✅

⏲️ Total pipeline duration: 12mn03s

Step Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-zendesk-support docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@ChristoGrab ChristoGrab merged commit cc8d5cc into master Aug 9, 2023
@ChristoGrab ChristoGrab deleted the zendesk-spec branch August 9, 2023 17:41
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
* update zendesk support spec descriptions

* update changelog

* Update airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/spec.json

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

---------

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants