Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[file-based cdk] Remove CSV quoting_behavior config option #29388

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

brianjlai
Copy link
Contributor

Closes #28330

What

We did some testing and this option doesn't appear to make a difference in the legacy S3 connector. We can use the default value QUOTE_MINIMAL for the CSV dialect to get the quoting behavior needed for the legacy connector (with newlines).

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/source/s3 labels Aug 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@brianjlai brianjlai marked this pull request as ready for review August 13, 2023 02:27
@brianjlai brianjlai requested a review from a team as a code owner August 13, 2023 02:27
@octavia-squidington-iii
Copy link
Collaborator

source-s3 test report (commit 75f4c850b3) - ✅

⏲️ Total pipeline duration: 10mn59s

Step Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-s3 docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@octavia-squidington-iii
Copy link
Collaborator

source-s3 test report (commit 0adec5fdba) - ✅

⏲️ Total pipeline duration: 13mn19s

Step Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-s3 docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@octavia-squidington-iii
Copy link
Collaborator

source-s3 test report (commit facb8cda0b) - ✅

⏲️ Total pipeline duration: 04mn34s

Step Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-s3 docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Aug 14, 2023
@brianjlai brianjlai merged commit 5908b85 into master Aug 15, 2023
@brianjlai brianjlai deleted the brian/remove_quoting_behavior branch August 15, 2023 00:37
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
…#29388)

* remove CSV quoting_behavior config option

* cleanup after getting latest master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit connectors/source/s3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[file-based cdk] Remove CSV quoting_behavior config option
4 participants