Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination snowflake: test tweaks #29402

Merged
merged 7 commits into from
Aug 15, 2023
Merged

Destination snowflake: test tweaks #29402

merged 7 commits into from
Aug 15, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Aug 14, 2023 •
edited
Loading

move a test with a hardcoded config out of the base class and into the subclass. It only needs to run once rather than once per subclass.

add some readme notes + disable tests that look annoying to fix.

@edgao edgao requested a review from a team as a code owner August 14, 2023 15:45
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023 •
edited by edgao
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii
Copy link
Collaborator

destination-snowflake test report (commit cf90d467e9) - ❌

⏲️ Total pipeline duration: 46mn16s

Step Result
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml ✅
Connector version semver check ✅
QA checks ✅
Build connector tar ✅
Build destination-snowflake docker image for platform linux/x86_64 ✅
Build airbyte/normalization-snowflake:dev ✅
./gradlew :airbyte-integrations:connectors:destination-snowflake:integrationTest ❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

@edgao edgao mentioned this pull request Aug 14, 2023
Merged
@octavia-squidington-iii
Copy link
Collaborator

destination-snowflake test report (commit 5ae1bd57b9) - ❌

⏲️ Total pipeline duration: 45mn53s

Step Result
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml ✅
Connector version semver check ✅
QA checks ✅
Build connector tar ✅
Build destination-snowflake docker image for platform linux/x86_64 ✅
Build airbyte/normalization-snowflake:dev ✅
./gradlew :airbyte-integrations:connectors:destination-snowflake:integrationTest ❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

@octavia-squidington-iii
Copy link
Collaborator

destination-snowflake test report (commit eafe65b2d0) - ✅

⏲️ Total pipeline duration: 44mn37s

Step Result
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml ✅
Connector version semver check ✅
QA checks ✅
Build connector tar ✅
Build destination-snowflake docker image for platform linux/x86_64 ✅
Build airbyte/normalization-snowflake:dev ✅
./gradlew :airbyte-integrations:connectors:destination-snowflake:integrationTest ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

cynthiaxyin
cynthiaxyin approved these changes Aug 14, 2023
View reviewed changes
airbyte-integrations/connectors/destination-snowflake/README.md
grant all privileges on schema INTEGRATION_TEST_DESTINATION.TEXT_SCHEMA to role NO_ACTIVE_WAREHOUSE_ROLE;
```

These tests are currently disabled (`testCheckWithNoProperStagingPermissionConnection`, `testCheckWithNoActiveWarehouseConnection`). Their test users keep breaking (i.e. becoming the schema owner) because our tests are tearing down `TEXT_SCHEMA` after every test.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL this doc exists.

@edgao edgao merged commit 4be5f4b into master Aug 15, 2023
@edgao edgao deleted the edgao/snowflake_tests branch August 15, 2023 15:05
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
@edgao @harrytou
Destination snowflake: disable broken tests (airbytehq#29402)
cc66a76 
* move test out of base class

* add setup instructions

* also grant privileges to the default role

* change owner

* username

* ffs

* am dummb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cynthiaxyin cynthiaxyin cynthiaxyin approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/destination/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgao @octavia-squidington-iii @cynthiaxyin