Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source SalesForce: update service level #29403

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

artem1205
Copy link
Collaborator

What

update service elvel

How

update metadata

Recommended reading order

  1. metadata.yaml

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205 artem1205 requested a review from davydov-d August 14, 2023 17:00
@octavia-squidington-iii
Copy link
Collaborator

source-salesforce test report (commit 2fd9e4155c) - ❌

⏲️ Total pipeline duration: 57mn45s

Step Result
Validate airbyte-integrations/connectors/source-salesforce/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-salesforce docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-salesforce test

@artem1205
Copy link
Collaborator Author

@bnchrch , I guess we're a little rushed with changes, as metadata validation tests failed:

Validating metadata.yaml...
metadata.yaml is not a valid ConnectorMetadataDefinitionV0 YAML file.
Validation error: 1 validation error for ConnectorMetadataDefinitionV0
data -> ab_internal -> sl
unexpected value; permitted: 100, 200, 300 (type=value_error.const; given=400; permitted=(100, 200, 300))

@bnchrch
Copy link
Contributor

bnchrch commented Aug 14, 2023

@artem1205 Ah! I had made a mistake in the docs.

We should be changing data.ab_internal.ql to 400

not data.ab_internal.sl

Im sorry about that.

@octavia-squidington-iii
Copy link
Collaborator

source-salesforce test report (commit 51d5b98a47) - ✅

⏲️ Total pipeline duration: 85mn14s

Step Result
Validate airbyte-integrations/connectors/source-salesforce/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-salesforce docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-salesforce test

@artem1205 artem1205 merged commit 4aff2b2 into master Aug 14, 2023
@artem1205 artem1205 deleted the artem1205/source-salesforce-update-internal-sl branch August 14, 2023 20:13
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
* Source SalesForce: update service level

* Source SalesForce: update ql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants