Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update Google search console docs #29416

Merged
merged 8 commits into from
Aug 15, 2023
Merged

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Aug 14, 2023

What

Updated the in-app and main docs pages for GSC source connector

How

  • Clarified use cases for authentication options. The current instructions were a bit murky particularly in regards to the nature of delegating domain-wide authority to a service account. My understanding is this step is meant for specific use cases where the service account will be accessing data from multiple users across a Google Workspace domain, and therefore needs to be granted 'carte blanche' access by a super admin. I've tried to make it clearer that this is a case-specific requirement for service accounts rather than a separate authentication option. Let me know if this still needs to be clarified further, or if I'm misunderstanding the nature of this functionality!
  • Updated connector setup instructions for both pages
  • Added separate sections for Custom Reports and Data State with additional context/examples. Setup steps link to these sections where appropriate

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 14, 2023
@ChristoGrab ChristoGrab requested a review from sherifnada August 14, 2023 22:40
@ChristoGrab ChristoGrab marked this pull request as ready for review August 14, 2023 22:41
* Enable Google Search Console API
- A verified property in Google Search Console
- Google Search Console API enabled for your project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only true for OSS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, added in the env tags and an (OSS only) note

- **For Airbyte Cloud**: Select **Oauth** from the Authentication dropdown, then click **Sign in with Google** to authorize your account. More information on authentication methods can be found in our [full Google Search Console documentation](https://docs.airbyte.io/integrations/sources/google-search-console#setup-guide).
<!-- /env:cloud -->
<!-- env:oss -->
- **For Airbyte Open Source**: Select **Service Account Key Authorization** from the Authentication dropdown, then enter the **Admin Email** and **Service Account JSON Key**. For the key, copy and paste the JSON key you obtained during the service account setup. It should begin with `{"type": "service account", "project_id": YOUR_PROJECT_ID, "private_key_id": YOUR_PRIVATE_KEY, ...}`. More information on setting up a service account and generating the JSON key can be found in our [full Google Search Console documentation](https://docs.airbyte.io/integrations/sources/google-search-console#setup-guide).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reference they can still use oauth in oss but they need to create their own oauth app. IDK if we need to list out the setup process for them, but let's at least mention that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I added the option to both docs pages and a link to Google's setup guide for creating the auth app


### Creating a Google service account
#### II: Google service account with JSON key file (Recommended for Airbyte Open Source)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we hide this for cloud?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone ahead and added the tags just in case, but I don't think they have any effect on the main page when an in-app page exists, since the latter is the one that gets displayed in the Airbyte UI

@@ -121,6 +105,52 @@ Parameter `data_state='all'` should not be used with Incremental Sync mode as it
- [Analytics site report by site](https://developers.google.com/webmaster-tools/search-console-api-original/v3/searchanalytics/query)
- Analytics report by custom dimensions

## Connector-specific configurations

### Custom reports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition!


You can use the [Google APIS Explorer](https://developers.google.com/webmaster-tools/v1/searchanalytics/query) to build and test the reports you want to use.

### Data State
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this option and section be called data freshness instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition on this section btw, nice work!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah I think data freshness makes sense, I've made the changes here and added the new title to the spec PR

@ChristoGrab ChristoGrab merged commit 0042d64 into master Aug 15, 2023
@ChristoGrab ChristoGrab deleted the google-search-console-docs branch August 15, 2023 17:16
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
* add sections for data state and custom reports

* service account edits

* full rework of setup steps

* edits

* edits

* quick fix

* add auth links to inapp page

* add oauth for oss, data state to data freshness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation connectors/source/google-search-console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants