Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rbroughan/add retry docs #29421

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Rbroughan/add retry docs #29421

merged 4 commits into from
Aug 15, 2023

Conversation

tryangul
Copy link
Contributor

What

Adds docs for new retry behavior. To be merged after OSS released.

How

Updates some docs

Recommended reading order

N/A

Let me know if I need to take any further steps to get the docs properly updated.

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2023

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 15, 2023
@tryangul tryangul requested a review from davinchia August 15, 2023 00:46
* 10 total attempts where no data was synchronized
* 10 total attempts where some data was synchronized

For oss users, these values are configurable. See [Configuring Airbyte](../operator-guides/configuring-airbyte.md#jobs) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1!


* 5 subsequent attempts where no data was synchronized
* 10 total attempts where no data was synchronized
* 10 total attempts where some data was synchronized
Copy link
Contributor

@davinchia davinchia Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: probably useful to add an example for illustration here, especially for a more complicated case of combination of partial and failed attempts and backoffs.

e.g.
attempt 1: partial success
attempt 2: failed
attempt 3: failed
attempt 4: partial success

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably after the retry backoff section so we cover the entire feature fully.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas on what kind of visualization would work best? All I can think of is a table

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a table seems fine to start.

the main thing is to be explain when backoff happens and how the configured variable affect how many failed attempts and total attempt in a complicated case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a pass at a table

@@ -10,7 +10,7 @@ To review the sync summary:

:::note

Airbyte will try to sync your data five times. After a fifth failure, it will stop attempting to sync.
In the event of a failure, Airbyte will make several attempts to sync your data before giving up. The latest rules can be read about [here](../../understanding-airbyte/jobs.md#retry-rules).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since Airbyte Cloud can have different retry configs from OSS, I wonder if we should have explicit Airbyte Cloud configs listed here.

for now, probably no need since Cloud <> OSS is the same.

Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

One minor comment, otherwise +1 for great docs!

@tryangul tryangul merged commit 4dba9dd into master Aug 15, 2023
@tryangul tryangul deleted the rbroughan/add-retry-docs branch August 15, 2023 16:53
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
* Update docs with basic attempt information.

* Add backoff and env vars docs.

* Currently -> by default.

* Add retry attempt example tables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants