Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Facebook Marketing: add unit test #29642

Merged
merged 13 commits into from
Aug 21, 2023
Merged

Source Facebook Marketing: add unit test #29642

merged 13 commits into from
Aug 21, 2023

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Aug 19, 2023 •
edited
Loading

What

Resolve https://github.com/airbytehq/oncall/issues/2765

How

Automatically reduce batch size / 2 if Too much data was requested in batch.

set maximum for max_batch_size = 50 (Facebook limitation)

Recommended reading order

  1. base_streams.py
  2. test_base_streams.py

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing labels Aug 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2023 •
edited by artem1205
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205
Merge remote-tracking branch 'origin/master' into artem1205/source-fa…
f116a8c 
…cebook-marketing-OC-2765

# Conflicts:
#	airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams/base_streams.py
@octavia-squidington-iii octavia-squidington-iii removed the area/documentation Improvements or additions to documentation label Aug 19, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 19, 2023
@artem1205 artem1205 requested review from girarda and lazebnyi August 19, 2023 08:05
@artem1205 artem1205 marked this pull request as ready for review August 19, 2023 08:05
@github-actions
Copy link
Contributor

source-facebook-marketing test report (commit 95d0e93666) - ❌

⏲️ Total pipeline duration: 87mn01s

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@artem1205 artem1205 changed the title Artem1205/source facebook marketing oc 2765 Source Facebook Marketing: add unit test Aug 19, 2023
@artem1205 artem1205 self-assigned this Aug 19, 2023
girarda
girarda approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good, and it'll prevent the connector from getting into a loop if requests fail with a batch size of 1, but I don't think it'll solve the issue in https://github.com/airbytehq/oncall/issues/2765 since we've seen failures with a batch size of 1.

@artem1205
Copy link
Collaborator Author

the change looks good, and it'll prevent the connector from getting into a loop if requests fail with a batch size of 1, but I don't think it'll solve the issue in airbytehq/oncall#2765 since we've seen failures with a batch size of 1.

I'll check this connection: https://cloud.airbyte.com/workspaces/cdef28c7-b641-4123-b9b6-baf9d9f56ea5/connections/a640dd3b-8e22-49f6-8120-177fb27b33ba/job-history,
Maybe turning off the batching mechanism could help us solve this problem, if it is so then we could use try..except to switch to a normal flow (without batch).

@github-actions
Copy link
Contributor

source-facebook-marketing test report (commit d7ee6ddadc) - ❌

⏲️ Total pipeline duration: 79mn46s

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@github-actions
Copy link
Contributor

source-facebook-marketing test report (commit 778b25e372) - ❌

⏲️ Total pipeline duration: 53mn54s

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@github-actions
Copy link
Contributor

source-facebook-marketing test report (commit 44b58ce53f) - ❌

⏲️ Total pipeline duration: 79mn13s

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@github-actions
Copy link
Contributor

source-facebook-marketing test report (commit 5200126537) - ❌

⏲️ Total pipeline duration: 59mn02s

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@github-actions
Copy link
Contributor

source-facebook-marketing test report (commit cd97f40ecd) - ✅

⏲️ Total pipeline duration: 79mn08s

Step Result
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@artem1205 artem1205 merged commit 7b72fc9 into master Aug 21, 2023
@artem1205 artem1205 deleted the artem1205/source-facebook-marketing-OC-2765 branch August 21, 2023 10:56
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
@artem1205 @harrytou
Source Facebook Marketing: add unit test (airbytehq#29642)
098b1ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

@lazebnyi lazebnyi Awaiting requested review from lazebnyi

Assignees

@artem1205 artem1205

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artem1205 @girarda @octavia-squidington-iii