Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup IP addresses in docs #29975

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Cleanup IP addresses in docs #29975

merged 3 commits into from
Aug 31, 2023

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Aug 29, 2023

Cleans up the Airbyte Security page to not list US IPs additionally under EU IPs anymore, since that's no longer required. Also removes the explicit copy of IP addresses in the postgres docs, since we're trying not to duplicate those IPs across docs, since it has shown to load to outdated docs more often and is harder to maintain. Also add "cloud only" env tags in the postgres docs to hide the full section in Airbyte OSS deployments.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 29, 2023
Copy link
Contributor

@nataliekwong nataliekwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@timroes timroes merged commit 9fd433b into master Aug 31, 2023
@timroes timroes deleted the tim/ip-cleanup branch August 31, 2023 13:59
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
Co-authored-by: timroes <timroes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants