DV2 sqlgenerator test: use generator.createTable instead of custom createTable method #30037

edgao · 2023-08-31T15:35:51Z

quick test refactor to simplify implementing #30010

github-actions · 2023-08-31T15:36:25Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

github-actions · 2023-08-31T15:54:55Z

destination-bigquery test report (commit `8688acb489`) - ✅

⏲️ Total pipeline duration: 15mn36s

Step	Result
Java Connector Unit Tests	✅
Build connector tar	✅
Build destination-bigquery docker image for platform linux/x86_64	✅
Java Connector Integration Tests	✅
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

github-actions · 2023-08-31T16:08:47Z

destination-snowflake test report (commit `8688acb489`) - ✅

⏲️ Total pipeline duration: 13mn41s

Step	Result
Java Connector Unit Tests	✅
Build connector tar	✅
Build destination-snowflake docker image for platform linux/x86_64	✅
Java Connector Integration Tests	✅
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

cynthiaxyin · 2023-08-31T18:00:07Z

airbyte-integrations/connectors/source-clockify/source_clockify/spec.yaml

@@ -4,8 +4,8 @@ connectionSpecification:
  title: Clockify Spec
  type: object
  required:
-  - workspace_id
-  - api_key
+    - workspace_id


Does some new formatting stuff run automatically now? Curious since you didn't make any changes to these files.

yeah, I think the format task now runs on the entire project? iirc this is new as of last week

github-actions · 2023-08-31T18:21:01Z

destination-snowflake test report (commit `e994b9ee08`) - ✅

⏲️ Total pipeline duration: 13mn28s

Step	Result
Java Connector Unit Tests	✅
Build connector tar	✅
Build destination-snowflake docker image for platform linux/x86_64	✅
Java Connector Integration Tests	✅
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

github-actions · 2023-08-31T18:36:23Z

destination-bigquery test report (commit `e994b9ee08`) - ✅

⏲️ Total pipeline duration: 15mn10s

Step	Result
Java Connector Unit Tests	✅
Build connector tar	✅
Build destination-bigquery docker image for platform linux/x86_64	✅
Java Connector Integration Tests	✅
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

…eateTable method (airbytehq#30037) Co-authored-by: edgao <edgao@users.noreply.github.com>

just use generator.createTable

8d6d7a9

edgao requested a review from a team as a code owner August 31, 2023 15:35

octavia-squidington-iii added area/connectors Connector related issues connectors/destination/bigquery connectors/destination/snowflake labels Aug 31, 2023

remove unrelated change

8688acb

Automated Commit - Formatting Changes

34b4916

jbfbell approved these changes Aug 31, 2023

View reviewed changes

cynthiaxyin approved these changes Aug 31, 2023

View reviewed changes

Merge branch 'master' into edgao/dv2/tests/refactor_create_table

e994b9e

edgao enabled auto-merge (squash) August 31, 2023 18:05

edgao merged commit 2d941ba into master Aug 31, 2023

edgao deleted the edgao/dv2/tests/refactor_create_table branch August 31, 2023 18:36

harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023

DV2 sqlgenerator test: use generator.createTable instead of custom cr…

823f072

…eateTable method (airbytehq#30037) Co-authored-by: edgao <edgao@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DV2 sqlgenerator test: use generator.createTable instead of custom createTable method #30037

DV2 sqlgenerator test: use generator.createTable instead of custom createTable method #30037

edgao commented Aug 31, 2023

github-actions bot commented Aug 31, 2023

github-actions bot commented Aug 31, 2023

github-actions bot commented Aug 31, 2023

cynthiaxyin Aug 31, 2023

edgao Aug 31, 2023

github-actions bot commented Aug 31, 2023

github-actions bot commented Aug 31, 2023

DV2 sqlgenerator test: use generator.createTable instead of custom createTable method #30037

DV2 sqlgenerator test: use generator.createTable instead of custom createTable method #30037

Conversation

edgao commented Aug 31, 2023

github-actions bot commented Aug 31, 2023

Before Merging a Connector Pull Request

github-actions bot commented Aug 31, 2023

destination-bigquery test report (commit 8688acb489) - ✅

github-actions bot commented Aug 31, 2023

destination-snowflake test report (commit 8688acb489) - ✅

cynthiaxyin Aug 31, 2023

Choose a reason for hiding this comment

edgao Aug 31, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 31, 2023

destination-snowflake test report (commit e994b9ee08) - ✅

github-actions bot commented Aug 31, 2023

destination-bigquery test report (commit e994b9ee08) - ✅

destination-bigquery test report (commit `8688acb489`) - ✅

destination-snowflake test report (commit `8688acb489`) - ✅

destination-snowflake test report (commit `e994b9ee08`) - ✅

destination-bigquery test report (commit `e994b9ee08`) - ✅