Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #29660] support empty keys with record selection #30057

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Aug 31, 2023

What

Addresses #29660

How

Import/set dpath option when source package is being loaded

🚨 User Impact 🚨

Anyone who import the source package will also import dpath which might slow things a bit but we expect this to be negligible.

Else, we can not have record selection with body like this:

{
    "": "value for empty key",
    "data": [
        {
            "record_key": 1
        },
        {
            "record_key": 2
        }
    ]
}

@maxi297 maxi297 requested a review from a team as a code owner August 31, 2023 20:08
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Aug 31, 2023
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@maxi297 maxi297 merged commit 63d3e40 into master Aug 31, 2023
@maxi297 maxi297 deleted the issue-29660/allow-empty-string--in-response-with-record-selection branch August 31, 2023 22:31
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants