Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escape quoting to selecting max (pk_field) query #30059

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

akashkulk
Copy link
Contributor

Context : https://airbytehq-team.slack.com/archives/C05K549RNRG/p1693494994891629?thread_ts=1693452295.425359&cid=C05K549RNRG

max_pk fields can collide with MySQL reserved keywords. As a result, we should have these escape quoted

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@akashkulk akashkulk marked this pull request as ready for review August 31, 2023 20:36
@akashkulk akashkulk requested a review from a team as a code owner August 31, 2023 20:36
@github-actions
Copy link
Contributor

source-mysql test report (commit 750208f300) - ❌

⏲️ Total pipeline duration: 36mn30s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@github-actions
Copy link
Contributor

source-mysql test report (commit 3b27aa1b55) - ❌

⏲️ Total pipeline duration: 36mn21s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@akashkulk
Copy link
Contributor Author

/approve-and-merge reason="mysql tests passing locally"

@octavia-approvington
Copy link
Contributor

You did it!
finish line

@octavia-approvington octavia-approvington merged commit 86b4e03 into master Aug 31, 2023
@octavia-approvington octavia-approvington deleted the fix_select_max_quotes branch August 31, 2023 23:01
@github-actions
Copy link
Contributor

source-mysql test report (commit 8ae9b3726a) - ❌

⏲️ Total pipeline duration: 18mn48s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants