Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source TikTok Marketing: use default availability strategy #31537

Merged
merged 6 commits into from
Oct 18, 2023
Merged

✨ Source TikTok Marketing: use default availability strategy #31537

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8442137
use default availability strategy
davydov-d Oct 18, 2023
318e50f
update changelog
davydov-d Oct 18, 2023
d0741a4
update expected records
davydov-d Oct 18, 2023
49b7cbd
upd expected records
davydov-d Oct 18, 2023
12b08bd
one more update of expected records
davydov-d Oct 18, 2023
2edad39
expected records
davydov-d Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-tiktok-marketing/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ COPY source_tiktok_marketing ./source_tiktok_marketing
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=3.5.0
LABEL io.airbyte.version=3.6.0
LABEL io.airbyte.name=airbyte/source-tiktok-marketing
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 4bfac00d-ce15-44ff-95b9-9e3c3e8fbd35
dockerImageTag: 3.5.0
dockerImageTag: 3.6.0
dockerRepository: airbyte/source-tiktok-marketing
githubIssueLabel: source-tiktok-marketing
icon: tiktok.svg
Expand Down
5 changes: 0 additions & 5 deletions airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import pydantic
import requests
from airbyte_cdk.models import SyncMode
from airbyte_cdk.sources.streams.availability_strategy import AvailabilityStrategy
from airbyte_cdk.sources.streams.core import package_name_from_class
from airbyte_cdk.sources.streams.http import HttpStream
from airbyte_cdk.sources.utils.schema_helpers import ResourceSchemaLoader
Expand Down Expand Up @@ -172,10 +171,6 @@ def __init__(self, **kwargs):
self._advertiser_id = kwargs.get("advertiser_id")
self.is_sandbox = kwargs.get("is_sandbox")

@property
def availability_strategy(self) -> Optional["AvailabilityStrategy"]:
return None

def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
"""All responses have the similar structure:
{
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/tiktok-marketing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,7 @@ The connector is restricted by [requests limitation](https://ads.tiktok.com/mark

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:-------------------------------------------------------------------------------------------------|
| 3.6.0 | 2023-10-18 | [31537](https://github.com/airbytehq/airbyte/pull/31537) | Use default availability strategy |
| 3.5.0 | 2023-10-16 | [31445](https://github.com/airbytehq/airbyte/pull/31445) | Apply minimum date restrictions |
| 3.4.1 | 2023-08-04 | [29083](https://github.com/airbytehq/airbyte/pull/29083) | Added new `is_smart_performance_campaign` property to `ad groups` stream schema |
| 3.4.0 | 2023-07-13 | [27910](https://github.com/airbytehq/airbyte/pull/27910) | Added `include_deleted` config param - include deleted `ad_groups`, `ad`, `campaigns` to reports |
Expand Down