Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airbyte-ci: Generate binary files for airbyte-ci #31930
Airbyte-ci: Generate binary files for airbyte-ci #31930
Changes from all commits
2865e12
80d8514
56c272a
d68aca5
b3e941f
d382026
a20e9e5
cea4b2a
9254e6d
964a1ca
010470f
7b2664b
d64044b
2ab5b91
072b27a
043a7a6
726f287
9f12faa
248d584
f97ea25
77d6f47
1a4339b
0686c9e
f7dbb86
5accdc0
ab427b2
32c586b
0acb859
a45b667
5e79294
be26ee9
29edc93
0f89db3
ff9302e
ad101d5
3325528
90e666e
325fd2b
9863821
1ad6891
b4674d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we explain airbyte-ci developers how to build the binary locally in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
I'd suggest making this function always succeed (returns true or false)
And implement the raising logic at the caller level.
It'd be better to throw a
ClickException
as it has ashow
method to cleanly output errors tostderr
.I think taking this approach would help build more environment checks in a consolidated way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we store it in a constant variable at module level?