-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Pinterest - new streams #32299
Conversation
This reverts commit c128690.
fixed slices by disabling date slices for impropriety streams
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
airbyte-integrations/connectors/source-pinterest/source_pinterest/streams.py
Outdated
Show resolved
Hide resolved
…reams' into midavadim/31705-pinterest-new-streams
…reams' into midavadim/31705-pinterest-new-streams
@midavadim I pulled in master to make the CI format check run correctly |
airbyte-integrations/connectors/source-pinterest/acceptance-test-config.yml
Show resolved
Hide resolved
airbyte-integrations/connectors/source-pinterest/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
…reams' into midavadim/31705-pinterest-new-streams
airbyte-integrations/connectors/source-pinterest/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, please make sure to have a 🟢 Connectors CI before merging
What
Add missing streams
MLP: https://docs.google.com/document/d/1QfrLntfjJ-mKJHcn2O8eh9e46I6qhcjXtbD9vJmzQ98/edit
PIN_PROMOTION
PIN_PROMOTION_REPORT
PIN_PROMOTION_TARGETING_REPORT
PRODUCT_GROUP_REPORT
PRODUCT_GROUP_TARGETING_REPORT
KEYWORD
KEYWORD_REPORT
PRODUCT_ITEM_REPORT
CATALOG_FEED
CATALOG_PRODUCT_GROUPS
CUSTOMER_LIST
CONVERSION_TAG
AUDIENCE
How
Describe the solution
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
no impact
Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.0.0.1
Dockerfile
has version0.0.1
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog with an entry for the initial version. See changelog exampledocs/integrations/README.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:generateScaffolds
then checking in your changesUpdating the Python CDK
Airbyter
Before merging:
--use-local-cdk --name=source-<connector>
as optionsairbyte-ci connectors --use-local-cdk --name=source-<connector> test
After merging: