fast error message on docker creation error #32333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
postamar
approved these changes
Nov 9, 2023
| @@ -1 +1 @@ | |||
| version=0.4.6 | |||
| version=0.4.7 | |||
There was a problem hiding this comment.
Don't forget to test with useLocalCdk = true and bump the CDK dependency for source-postgres.
stephane-airbyte
deleted the
stephane/fast-error-message-on-docker-creation
branch
|
/publish-java-cdk
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test only change: On docker container creation error, we shouldn't return the docker container that's problematic. Instead, we should wrap the initial error message (except the 1st time it throws, where we can directly send the exception.
This way, we fail fast, and the error message actually makes sense.
Today, the error message we get on subsequent gets is something akin to "copyFileToContainer can only be used with created / running container".
source-postgres test report with error