-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show metadata on connector docs #32334
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to test something still later. Please hold back merging yet (in case you wake up before I'm getting to test this).
There's also something wacky with remark that's injecting an |
*/ | ||
const fetchCatalog = async () => { | ||
if (loading) { | ||
await sleep(500); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose for waiting here?
Ok, I think this is ready now. The comments have been addressed. I've replaced the timer and per-page invocation of Thanks for reminding me how real programming language work, @timroes! |
/s$/, | ||
"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evantahler Why are we generically removing any s
at the end of a connector type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I think I get it, this is only here to make destinations
-> destination
, sources
-> source
. I was misreading this as being executed on the actual name of the connector (which we often call the connector type in the rest of the product :D)
This PR loads up the latest metadata entry for connectors and injects useful info at the top of the page:
This is accomplished by adding a remark which adds some custom logic to the markdown processor. We download the latest version of the connector registry at build time and inject a new table at the top of the page showing some handy information:
Pros of this approach:
Cons of this approach: