Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Updates Sendgrid Source Connector Docs (Removes inapp page, adds <HideInUI>, adds Limitations & Troubleshooting) #32373

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

pnilan
Copy link
Contributor

@pnilan pnilan commented Nov 9, 2023

What

Updates for Sendgrid source connector docs pages. This update includes addition of new collapsible troubleshooting section, as well as the replacement of the "inapp" docs with the new tags per Issue #32069.

How

  • Removed in-app page
  • Added HideInUI tags to all sections other than Prerequisites and Setup Guide.
  • env tags handle sections to be displayed only in OSS vs Cloud pages.
  • Added Limitations & Troubleshooting section, per new suggested approach.

Main page vs In-app OSS (Example)

Shopify docs difference

Limitations & Troubleshooting Section (Example)

Limitations screenshot

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 5:43pm

@katmarkham katmarkham merged commit 1ab67da into master Nov 10, 2023
16 checks passed
@katmarkham katmarkham deleted the pnilan/sendgrid-docs-fix branch November 10, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants