-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java CDK: skip dropping database in PostgresTestDatabase::close #32377
java CDK: skip dropping database in PostgresTestDatabase::close #32377
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Coverage report for source-postgres
|
/publish-java-cdk
|
…aring-down-anything' into try-not-tearing-down-anything
/approve-and-merge reason="docker pull rate limit" |
This PR follows up on #32314
I profiled some tests and noticed that we spent an stupendous amount of time closing the
PostgresTestDatabase
instances. As it turns out,DROP DATABASE
is really slow. We don't need to do it so let's not.This PR also gets rid of the
tmpDir
because it's not actually needed.