Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ concurrent cdk: Read multiple streams concurrently #32411
✨ concurrent cdk: Read multiple streams concurrently #32411
Changes from 75 commits
95230db
fee9d5a
b49ddbd
c714cd6
84c6b50
6275446
18d87cd
18dc14a
149212a
03f53d6
e25f320
551a812
72fd3de
c7ea97a
a7a822a
1a76377
2f7878f
798fda7
438a0ea
1c3cd1c
c918082
2704468
b6596f7
2056d25
d8ef071
4157008
9a68f78
dbe9262
907755a
11ab634
0a7c3f2
acd78b8
39955e7
5185868
5b9fa3d
0600795
9254d55
29ee92f
7dc764c
e86b701
6843bfc
8ed60df
c5a5e99
60d1a74
6ddea7f
d2c3f86
d758fae
22aa854
7c8db6a
6bfed39
6b56ee8
a385b93
2b89ac9
cdc0d8f
6b8d34e
55203ec
63199fc
e2fe651
c84d150
623bdd9
e7a0493
cae8795
53c3c7e
700bb68
927e1bc
9a1c26e
df0d2ea
65cf274
fd68c3e
39a5f48
166d004
2ebfbf8
e914feb
c4816c8
5fa7bbe
8615786
197d9d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that availability checks can be time-consuming, is there any reason not to do this part concurrently? We can just put all the streams in the queue and let them be filtered out by the worker that's processing them.
That would make cost of the initial enqueuing of streams negligible and would allow us to simplify this method - we wouldn't need a separate
_submit_initial_partition_generators
step.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the checks on the worker is a good idea. I'll do in a separate PR