Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: re-enable caching on source-postgres CI #32427

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Nov 10, 2023

What

We disabled dagger caching for source-postgres while we were working on the improving its CI.
The main reason was to not bias our metrics during performance benchmarking.

How

  • Remove the cachebuster
  • Remove the tmp job which frequently ran the CI on source-postgres
  • Remove hack functions

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2023 1:51pm

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alafanechere alafanechere force-pushed the augustin/11-10-airbyte-ci_re-enable_caching_on_source-postgres_CI branch from e8c704a to d3fed11 Compare November 10, 2023 13:50
@alafanechere alafanechere marked this pull request as ready for review November 10, 2023 14:18
@alafanechere alafanechere requested review from a team and postamar November 10, 2023 14:18
@alafanechere alafanechere enabled auto-merge (squash) November 10, 2023 14:18
@postamar postamar disabled auto-merge November 10, 2023 16:19
Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please don't merge just yet I want to see the pretty graph in metabase go down over the weekend.

@alafanechere
Copy link
Contributor Author

alafanechere commented Nov 13, 2023

LGTM but please don't merge just yet I want to see the pretty graph in metabase go down over the weekend.

The graph went down by 2mn (8mn) over the weekend

@alafanechere alafanechere merged commit 7973311 into master Nov 13, 2023
17 checks passed
@alafanechere alafanechere deleted the augustin/11-10-airbyte-ci_re-enable_caching_on_source-postgres_CI branch November 13, 2023 08:31
@postamar
Copy link
Contributor

Yes it's very pretty! Thanks for indulging me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants