Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable javac checks #32467

Merged
merged 1 commit into from
Nov 14, 2023
Merged

enable javac checks #32467

merged 1 commit into from
Nov 14, 2023

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented Nov 13, 2023 •
edited
Loading

enabling javac errors for all connectors that don't have any errors. Disabling those for the connectors with issues

@vercel Vercel
Copy link

vercel bot commented Nov 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 10:45pm

@github-actions GitHub Actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@stephane-airbyte stephane-airbyte marked this pull request as ready for review November 13, 2023 19:41
@stephane-airbyte stephane-airbyte requested review from a team as code owners November 13, 2023 19:41
postamar
postamar approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy if the CI is happy.

airbyte-integrations/connectors/destination-exasol/target/id_rsa Outdated
d3M1+40QC8z1OV+Nn+MtFBqg3Hc15p1YqJ3BbBKDbCWFXdtNH4F09fCtTRoZ/oks
ZaQv0tLZGA7EzeWn/eYpAkEAyZHkJs2pjxrHKXs1c4UYyoDSkw2hYjH/xCyAo9sd
S4COjz7vFvC6/ezxFfmD6qGopD5Qh+YGuGu6Aae3oQC3jw==
-----END RSA PRIVATE KEY-----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this committed by mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, reverted

airbyte-integrations/connectors/destination-exasol/target/id_rsa.pub Outdated
@@ -0,0 +1 @@
ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAAAgQDndR9nviw2qpN52bIke+CuNwz3P6xMcTcK2Ggc6DTKpD372f4ukxhYgU3EPJXeklNnydgG3+WfNWQgwtwxArQYWiCZyeIjIX4Df3qEfr0VSPSuFYeCuyD2LWGdPYTP1LR09kyYtCs/Lgu9i3FJ3tc19gwkvtXsOBJZURV3+U4zHw==
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this committed by mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these secrets? They are in github history now, and need to be rolled...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they're all test-generated. I'm not sure how to remove them from the repo altogether. close the PR and delete the branch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it doesn't matter!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note, since we have so many popular forks, there actually is no functional way to remove our git history

@stephane-airbyte
ignore warnings for connectors with javac errors
f4bcb6b 
ignore warnings for more connectors

more javac warning ignores

ignore more javac warnings.
enable javac error for most connectors

Delete airbyte-integrations/connectors/destination-exasol/target/id_rsa

Delete airbyte-integrations/connectors/destination-exasol/target/id_rsa.pub

Delete airbyte-integrations/connectors/destination-teradata/ca.pem

deleted test files
@stephane-airbyte stephane-airbyte force-pushed the stephane/enable-javac-errors-1 branch from 7c70142 to f4bcb6b Compare November 13, 2023 22:44
@stephane-airbyte
Copy link
Contributor Author

/approve-and-merge reason="only changing build parameters. Too many connectors will run tests

@octavia-approvington
Copy link
Contributor

Myomoto says it looks good
thats a niiice

@octavia-approvington octavia-approvington merged commit c642d81 into master Nov 14, 2023
16 of 18 checks passed
@octavia-approvington octavia-approvington deleted the stephane/enable-javac-errors-1 branch November 14, 2023 00:08
@stephane-airbyte stephane-airbyte changed the title Stephane/enable javac errors 1 enable javac checks Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler left review comments

@octavia-approvington octavia-approvington octavia-approvington approved these changes

@postamar postamar postamar approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/destination/azure-blob-storage connectors/destination/cassandra connectors/destination/clickhouse connectors/destination/clickhouse-strict-encrypt connectors/destination/csv connectors/destination/databricks connectors/destination/dev-null connectors/destination/doris connectors/destination/dynamodb connectors/destination/e2e-test connectors/destination/elasticsearch connectors/destination/elasticsearch-strict-encryp connectors/destination/exasol connectors/destination/gcs connectors/destination/iceberg connectors/destination/kafka connectors/destination/keen connectors/destination/kinesis connectors/destination/local-json connectors/destination/mariadb-columnstore connectors/destination/mongodb connectors/destination/mongodb-strict-encrypt connectors/destination/mqtt connectors/destination/mssql connectors/destination/mssql-strict-encrypt connectors/destination/mysql connectors/destination/mysql-strict-encrypt connectors/destination/oracle connectors/destination/oracle-strict-encrypt connectors/destination/postgres connectors/destination/postgres-strict-encrypt connectors/destination/pubsub connectors/destination/pulsar connectors/destination/r2 connectors/destination/redis connectors/destination/redpanda connectors/destination/redshift connectors/destination/rockset connectors/destination/s3-glue connectors/destination/scylla connectors/destination/selectdb connectors/destination/starburst-galaxy connectors/destination/teradata connectors/destination/tidb connectors/destination/vertica connectors/destination/yugabytedb connectors/source/bigquery connectors/source/clickhouse connectors/source/clickhouse-strict-encrypt connectors/source/cockroachdb connectors/source/db2 connectors/source/dynamodb connectors/source/e2e-test connectors/source/e2e-test-cloud connectors/source/elasticsearch connectors/source/kafka connectors/source/mongodb-strict-encrypt connectors/source/mysql-strict-encrypt connectors/source/oracle connectors/source/oracle-strict-encrypt connectors/source/redshift connectors/source/sftp connectors/source/snowflake connectors/source/teradata connectors/source/tidb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephane-airbyte @octavia-approvington @evantahler @postamar @octavia-squidington-iii