Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove source-xero from Cloud #32476

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Nov 13, 2023

From slack

source-xero has been hidden from cloud for over a month as it is having oAuth issues. This makes it explicit that the connector is no longer available on cloud (docs, etc).

This will remove xero from the registry, but allow existing users to keep using the actors they have (the LaunchDarkly feature flag to hide Zero should remain enabled)

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Nov 13, 2023 10:37pm

Copy link
Contributor

github-actions bot commented Nov 13, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@evantahler evantahler marked this pull request as ready for review November 13, 2023 22:39
@evantahler evantahler enabled auto-merge (squash) November 13, 2023 22:40
Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we keep it hidden w/ the feature flag, LGTM!

@evantahler
Copy link
Contributor Author

/approve-and-merge reason="tests don't matter, removing connector from cloud"

@octavia-approvington
Copy link
Contributor

Jerry would be proud
Spongebob

@octavia-approvington octavia-approvington merged commit 6afac83 into master Nov 14, 2023
29 of 34 checks passed
@octavia-approvington octavia-approvington deleted the evan/no-xero-on-cloud branch November 14, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants