-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove source-xero from Cloud #32476
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as we keep it hidden w/ the feature flag, LGTM!
/approve-and-merge reason="tests don't matter, removing connector from cloud" |
From slack
source-xero has been hidden from cloud for over a month as it is having oAuth issues. This makes it explicit that the connector is no longer available on cloud (docs, etc).
This will remove xero from the registry, but allow existing users to keep using the actors they have (the LaunchDarkly feature flag to hide Zero should remain enabled)