Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load connector secrets in performance harness to pass acceptance test #32480

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Load connector secrets in performance harness to pass acceptance test #32480

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c274a8
be sure to load connector secrets for acceptance test
xiaohansong Nov 14, 2023
166ed2c
update connector parsing logic
xiaohansong Nov 14, 2023
c9ee98c
remove base prefix
xiaohansong Nov 14, 2023
0c1f20e
Merge remote-tracking branch 'origin/master' into xiaohan/credential_…
xiaohansong Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/connector-performance-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ jobs:
id: regex
uses: AsasInnab/regex-action@v1
with:
regex_pattern: "^((connectors|bases)/)?[a-zA-Z0-9-_]+$"
regex_pattern: "^(connectors/)?[a-zA-Z0-9-_]+$"
regex_flags: "i" # required to be set for this plugin
search_string: ${{ inputs.connector }}
- name: Validate input workflow format
Expand Down Expand Up @@ -179,6 +179,8 @@ jobs:
run: |
export PATH="$PATH:/root/.local/bin"
ci_credentials connectors-performance/$HARNESS_TYPE write-to-storage
connector_name=$(echo ${{ inputs.connector }} | sed 's,.*/,,')
ci_credentials connectors-performance/$connector_name write-to-storage
env:
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
HARNESS_TYPE: ${{ steps.which-harness.outputs.harness_type }}
Expand All @@ -195,7 +197,7 @@ jobs:
run: |
echo "Building... ${{inputs.connector}}" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY # this is a blank line
connector_name=$(echo ${{ inputs.connector }} | cut -d / -f 2)
connector_name=$(echo ${{ inputs.connector }} | sed 's,.*/,,')
echo "Running ./gradlew :airbyte-integrations:connectors:$connector_name:build -x check"
./gradlew :airbyte-integrations:connectors:$connector_name:build -x check
env:
Expand Down
Loading