format: airbyte-ci format fix all on PR / airbyte-ci format check all on master
#32491
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| name: Check for formatting errors on head ref | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.head_ref }} | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - master | ||
| jobs: | ||
| format-check: | ||
| runs-on: "conn-prod-xlarge-runner" | ||
| name: "Check for formatting errors on ${{ github.head_ref }}" | ||
| timeout-minutes: 40 | ||
| steps: | ||
| - name: Checkout Airbyte | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| ref: ${{ github.head_ref }} | ||
| token: ${{ secrets.GH_PAT_APPROVINGTON_OCTAVIA }} | ||
|
|
||
| - name: Run airbyte-ci format check | ||
| id: airbyte_ci_format_check_all | ||
| uses: ./.github/actions/run-dagger-pipeline | ||
| continue-on-error: true | ||
| with: | ||
| context: "master" | ||
| docker_hub_password: ${{ secrets.DOCKER_HUB_PASSWORD }} | ||
| docker_hub_username: ${{ secrets.DOCKER_HUB_USERNAME }} | ||
| gcs_credentials: ${{ secrets.METADATA_SERVICE_PROD_GCS_CREDENTIALS }} | ||
| sentry_dsn: ${{ secrets.SENTRY_AIRBYTE_CI_DSN }} | ||
| github_token: ${{ secrets.GH_PAT_MAINTENANCE_OCTAVIA }} | ||
| subcommand: "format check all" | ||
|
|
||
| # This is helpful in the case that we change a previously committed generated file to be ignored by git. | ||
| - name: Remove any files that have been gitignored | ||
| run: git ls-files -i -c --exclude-from=.gitignore | xargs -r git rm --cached | ||
|
|
||
| - name: Match GitHub User to Slack User | ||
| id: match-github-to-slack-user | ||
| uses: ./.github/actions/match-github-to-slack-user | ||
| env: | ||
| AIRBYTE_TEAM_BOT_SLACK_TOKEN: ${{ secrets.SLACK_AIRBYTE_TEAM_READ_USERS }} | ||
| GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Format Failure on Master Slack Channel | ||
| if: steps.airbyte_ci_format_check_all.outcome == 'failure' | ||
| uses: abinoda/slack-action@master | ||
| env: | ||
| SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN_AIRBYTE_TEAM }} | ||
| with: | ||
| args: >- | ||
| {\"channel\":\"C03BEADRPNY\", \"blocks\":[ | ||
| {\"type\":\"divider\"}, | ||
| {\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\"Formatting is broken on master! :bangbang: \n\n\"}}, | ||
| {\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\"_merged by_: *${{ github.actor }}* \n\"}}, | ||
| {\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\"<@${{ steps.match-github-to-slack-user.outputs.slack_user_ids }}> \n\"}}, | ||
| {\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\" :octavia-shocked: <https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}|View Action Run> :octavia-shocked: \n\"}}, | ||
| {\"type\":\"divider\"}]} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| name: Automatic Formatting on PRs | ||
|
|
||
|
There was a problem hiding this comment. You're going to want to follow the "fix" with a "check". Not everything can always be fixed automatically and formatting errors should be caught before the PR is merged. In fact, that's the DoD for this whole initiative. There was a problem hiding this comment. Done in 715a8e0 |
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
|
|
@@ -7,9 +7,6 @@ concurrency: | |
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| jobs: | ||
| format-fix: | ||
|
|
@@ -44,7 +41,7 @@ jobs: | |
| - '**/*' | ||
| - '!**/*.md' | ||
|
|
||
| - name: Run airbyte-ci format fix all | ||
| uses: ./.github/actions/run-dagger-pipeline | ||
| with: | ||
| context: "pull_request" | ||
|
|
@@ -68,31 +65,13 @@ jobs: | |
| commit_user_name: Octavia Squidington III | ||
| commit_user_email: octavia-squidington-iii@users.noreply.github.com | ||
|
|
||
| - name: Run airbyte-ci format check all | ||
| uses: ./.github/actions/run-dagger-pipeline | ||
| with: | ||
| context: "pull_request" | ||
| docker_hub_password: ${{ secrets.DOCKER_HUB_PASSWORD }} | ||
| docker_hub_username: ${{ secrets.DOCKER_HUB_USERNAME }} | ||
| gcs_credentials: ${{ secrets.METADATA_SERVICE_PROD_GCS_CREDENTIALS }} | ||
| sentry_dsn: ${{ secrets.SENTRY_AIRBYTE_CI_DSN }} | ||
| github_token: ${{ secrets.GH_PAT_MAINTENANCE_OCTAVIA }} | ||
| subcommand: "format check all" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocking comment but in the near future we're going to want to subsume a larger class of checks than just formatting checks in this workflow, so its name should reflect that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer keeping this name as it is as we don't know yet what's going to be in this "larger class of checks" and we might want to split them in multiple workflows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point