airbyte-ci: use binary in CI #32497
Merged
airbyte-ci: use binary in CI #32497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
alafanechere
force-pushed
the
augustin/11-14-airbyte-ci_use_binary_in_CI
branch
2 times, most recently
from
db2dcd1 to
c25b46d
Compare
evantahler
approved these changes
Nov 14, 2023
| - name: Run airbyte-ci | ||
| shell: bash | ||
| run: | | ||
| export _EXPERIMENTAL_DAGGER_RUNNER_HOST="unix:///var/run/buildkit/buildkitd.sock" | ||
| airbyte-ci --is-ci --gha-workflow-run-id=${{ github.run_id }} ${{ inputs.subcommand }} ${{ inputs.options }} | ||
| airbyte-ci --disable-dagger-run --is-ci --gha-workflow-run-id=${{ github.run_id }} ${{ inputs.subcommand }} ${{ inputs.options }} |
There was a problem hiding this comment.
what does --disable-dagger-run do?
There was a problem hiding this comment.
This is what enables the terminal UI when running locally.
We don't want this in CI because it might expose sensitive information / clutter the GHA logs.
It's called disable dagger run because getting the terminal UI is achieved by running dagger run airbyte-ci (using Dagger's CLI)
octavia-squidington-iii
added
area/connectors
|
|
alafanechere
force-pushed
the
augustin/11-14-airbyte-ci_use_binary_in_CI
branch
from
4ba9772 to
f703af6
Compare
octavia-squidington-iii
removed
CDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use our
airbyte-cilinux binary in the CIHow
Install Python 3.10andInstall ci-connector-ops packagesteps from.github/actions/run-dagger-pipeline/action.ymlInstall airbyte-ci binarystep to.github/actions/run-dagger-pipeline/action.ymlwhich curls the binary and moves it to/usr/local/binairbyte_ci_binary_urloption at the action level, defaults tolatest: can be useful to pin airbyte-ci version in the CI or tryout pre-releases--disable-dagger-runflagTODO
🚨 User Impact 🚨