-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Amazon Seller Partner: improve UX #32505
✨ Source Amazon Seller Partner: improve UX #32505
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
…artner-spec-refactor' into artem1205/source-amazon-seller-partner-spec-refactor
…azon-seller-partner-spec-refactor # Conflicts: # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py # airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_reports_stream_sales_and_traffic.py # airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_reports_streams_rate_limits.py
…azon-seller-partner-spec-refactor # Conflicts: # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json
…azon-seller-partner-spec-refactor # Conflicts: # airbyte-integrations/connectors/source-amazon-seller-partner/integration_tests/spec.json # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py # airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_finance_streams.py # airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_order_items_stream.py # airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_reports_stream_sales_and_traffic.py # airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_reports_streams_settlement_report.py # airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py
…artner-spec-refactor' into artem1205/source-amazon-seller-partner-spec-refactor
…efactor # Conflicts: # airbyte-integrations/connectors/source-amazon-seller-partner/metadata.yaml # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/schemas/GET_VENDOR_TRAFFIC_REPORT.json # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py # airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_finance_streams.py # airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_source.py # docs/integrations/sources/amazon-seller-partner.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need resolve conflicts before review
…c-refactor # Conflicts: # airbyte-integrations/connectors/source-amazon-seller-partner/metadata.yaml # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py # airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_finance_streams.py # airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_source.py # docs/integrations/sources/amazon-seller-partner.md
…artner-spec-refactor' into artem1205/source-amazon-seller-partner-spec-refactor
@lazebnyi The conflicts have been resolved. Please review, thanks! |
...ns/connectors/source-amazon-seller-partner/source_amazon_seller_partner/config_migrations.py
Outdated
Show resolved
Hide resolved
...-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What
Resolve #32225
How
Refactor report options
Report options
inconfig
:Recommended reading order
x.java
y.python
🚨 User Impact 🚨
no breaking changes
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.