-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async Destinations - Make debug messages less scary #32526
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Connector related issues
connectors/destination/bigquery
connectors/destination/snowflake
labels
Nov 14, 2023
edgao
approved these changes
Nov 14, 2023
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Nov 14, 2023
FYI @benmoriceau and @tryangul |
tryangul
approved these changes
Nov 15, 2023
Contributor
Author
/publish-java-cdk
|
CDK Published, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
CDK
Connector Development Kit
connectors/destination/bigquery
connectors/destination/snowflake
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32465
This PR adjusts the logging frequency and content of Destination Async framework. Prior to this PR logs like this would happen every 10 seconds:
These logs are verbose, slow down log rendering, and look like something is wrong with the destination.
After this PR: