Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨🚨🐛 Source Pinterest: Update date-time fields with airbyte_type: timestamp_without_timezone #32595

Merged
merged 5 commits into from
Nov 21, 2023
Merged

🚨🚨🐛 Source Pinterest: Update date-time fields with airbyte_type: timestamp_without_timezone #32595

merged 5 commits into from
Nov 21, 2023

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Nov 16, 2023

What

The format of timestamp fields has been updated to include "airbyte_type": "timestamp_without_timezone". This modification aligns the timestamp fields with Airbyte's data standards.

🚨 User Impact 🚨

This PR introduces breaking changes due to changing field type by adding airbyte_type for timestamp fields. Users will have to refresh their schemas and refresh data after the upgrade.

@vercel Vercel
Copy link

vercel bot commented Nov 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 11:27am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited by tolik0
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 16, 2023
@tolik0 tolik0 marked this pull request as ready for review November 16, 2023 14:30
@octavia-squidington-iv octavia-squidington-iv requested review from a team November 16, 2023 14:31
katmarkham
katmarkham requested changes Nov 16, 2023
View reviewed changes
airbyte-integrations/connectors/source-pinterest/metadata.yaml Outdated
message:
This release updates the date-time fields to use the Airbyte format `timestamp_without_timezone`.
This change affects all streams where date-time fields are present, ensuring more accurate and standardized time representations.
Users will need to refresh the source schema and reset affected streams after upgrading.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and reset streams BoardPins, BoardSectionPins, Boards, Catalogs, and CatalogFeeds after upgrading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2023-11-16 19-30-48
"Reset affected streams" is the name of the check option in the UI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This release updates the date-time fields to use the Airbyte format timestamp_without_timezone.
This change affects all streams where date-time fields are present, ensuring more accurate and standardized time representations: BoardPins, BoardSectionPins, Boards, Catalogs, and CatalogFeeds.
Users will need to refresh the source schema and reset affected streams after upgrading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

docs/integrations/sources/pinterest-migrations.md Outdated

This release updates date-time fields with airbyte_type: timestamp_without_timezone for streams BoardPins, BoardSectionPins, Boards, Catalogs, CatalogFeeds.

Users should:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure uninterrupted syncs, users should:

  • Refresh the source schema
  • Reset affected streams

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 16, 2023 17:22
@tolik0 tolik0 force-pushed the tolik0/source-pinterest/fix-date-validation branch from 502e8fb to 583deb4 Compare November 16, 2023 17:41
@tolik0 tolik0 requested a review from katmarkham November 16, 2023 21:06
@tolik0 tolik0 self-assigned this Nov 17, 2023
@tolik0 tolik0 changed the base branch from master to dev November 21, 2023 11:16
@tolik0 tolik0 force-pushed the tolik0/source-pinterest/fix-date-validation branch from fc635a9 to 318688b Compare November 21, 2023 11:27
@tolik0 tolik0 merged commit 0f28144 into dev Nov 21, 2023
26 checks passed
@tolik0 tolik0 deleted the tolik0/source-pinterest/fix-date-validation branch November 21, 2023 11:47
git-phu pushed a commit that referenced this pull request Nov 28, 2023
@tolik0 @git-phu
🚨🚨🐛 Source Pinterest: Update date-time fields with airbyte_type: time…
227e954 
…stamp_without_timezone (#32595)
git-phu pushed a commit that referenced this pull request Nov 28, 2023
@tolik0 @git-phu
🚨🚨🐛 Source Pinterest: Update date-time fields with airbyte_type: time…
1f87374 
…stamp_without_timezone (#32595)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katmarkham katmarkham katmarkham approved these changes

@bazarnov bazarnov bazarnov approved these changes

Assignees

@tolik0 tolik0

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/pinterest team/connectors-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tolik0 @bazarnov @katmarkham @octavia-squidington-iii