Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST CI: Benign docstring change #32630

Merged
merged 2 commits into from
Nov 17, 2023
Merged

TEST CI: Benign docstring change #32630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
155f123
Benign docstring change
bnchrch Nov 17, 2023
360b35b
Handle static args
bnchrch Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/approve-and-merge-demo-dispatch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,16 @@ jobs:
checkFormat:
runs-on: ubuntu-latest
steps:
- name: Dump the client payload context
env:
PAYLOAD_CONTEXT: ${{ toJson(github.event.client_payload) }}
run: echo "$PAYLOAD_CONTEXT"
- name: Wait for formatters to succeed
id: wait-for-formatters
uses: lewagon/wait-on-check-action@v1.3.1
with:
ref: ${{ github.ref }}
check-name: "Apply All Formatting Rules"
ref: ${{ github.event.client_payload.slash_command.args.named.gitref }}
check-name: "Check for formatting errors on"
repo-token: ${{ secrets.GH_PAT_APPROVINGTON_OCTAVIA }}
wait-interval: 30
- name: Comment if formatters failed
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/slash-commands.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ jobs:
permission: write
commands: |
approve-and-merge-demo
static-args: |
repo=${{ steps.getref.outputs.repo }}
gitref=${{ steps.getref.outputs.ref }}
comment-id=${{ github.event.comment.id }}
dispatch-type: repository

- name: Edit comment with error message
Expand Down
2 changes: 1 addition & 1 deletion airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/test/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
@pass_pipeline_context
@click_ignore_unused_kwargs
async def test(pipeline_context: ClickPipelineContext):
"""Runs the tests for the given airbyte-ci package
"""Runs the tests for the given airbyte-ci package.

Args:
pipeline_context (ClickPipelineContext): The context object.
Expand Down
Loading