Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Pinterest: Fix Advertiser stream names #32734

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Nov 22, 2023

What

In this PR, the stream names AdvertizerReport and AdvertizerTargetingReport have been renamed to AdvertiserReport and AdvertiserTargetingReport, respectively.
The version bump is skipped to avoid releasing unnecessary breaking changes. This PR incorporates changes into the previously merged 1.0.0 breaking changes release, which has not yet been released due to the code freeze.

Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview Nov 22, 2023 4:21pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 22, 2023
@tolik0 tolik0 changed the base branch from master to dev November 22, 2023 16:21
Copy link
Contributor

github-actions bot commented Nov 22, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@tolik0 tolik0 marked this pull request as ready for review November 22, 2023 16:24
@tolik0 tolik0 requested review from lazebnyi and a team November 22, 2023 16:24
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 22, 2023 16:25
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!

@tolik0 tolik0 self-assigned this Nov 23, 2023
@tolik0 tolik0 merged commit 667be92 into dev Nov 23, 2023
33 of 39 checks passed
@tolik0 tolik0 deleted the tolik0/source-pinterest/fix-advertiser-stream-name branch November 23, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/pinterest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants