Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Source Pinterest: Update docs and spec; add missing placement_traffic_type field to AdGroups stream #32747

Merged
merged 5 commits into from
Nov 23, 2023
Merged

✨ Source Pinterest: Update docs and spec; add missing placement_traffic_type field to AdGroups stream #32747

merged 5 commits into from
Nov 23, 2023

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Nov 22, 2023

What

This PR introduces a series of enhancements to the Pinterest source connector, focusing on documentation improvements and the addition of a new field to the AdGroups stream. These changes are designed to simplify the setup process and enhance the utility of the connector:

  • Custom Reports Section Added: A new section explaining the creation of personalized analytics reports within the connector.
  • Revised Setup Guide: Updated instructions for both Airbyte Cloud and Open Source versions, enhancing user understanding and ease of setup.
  • Updated Prerequisites with OAuth Permissions: Expanded details on the OAuth permissions required for setup, including a link to Pinterest's API Scopes documentation for comprehensive understanding.
  • Added 'placement_traffic_type' Field to AdGroups Stream: This field has been included to provide more detailed data in the AdGroups stream.

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2023 11:51am

@tolik0 tolik0 self-assigned this Nov 22, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/pinterest labels Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited by tolik0
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@tolik0 tolik0 requested review from brianjlai and a team November 22, 2023 21:38
@tolik0 tolik0 marked this pull request as ready for review November 22, 2023 21:38
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 22, 2023 21:39
brianjlai
brianjlai approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Nice work on the improved documentation

@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 23, 2023 09:20
@tolik0 tolik0 force-pushed the tolik0/source-pinterest/checklist-updates branch from dcd6193 to 50108a6 Compare November 23, 2023 11:51
@tolik0 tolik0 merged commit 059ca2f into dev Nov 23, 2023
21 of 24 checks passed
@tolik0 tolik0 deleted the tolik0/source-pinterest/checklist-updates branch November 23, 2023 13:01
git-phu pushed a commit that referenced this pull request Nov 28, 2023
@tolik0 @git-phu
✨ Source Pinterest: Update docs and spec; add missing `placement_traf…
09f88c6 
…fic_type` field to AdGroups stream (#32747)
git-phu pushed a commit that referenced this pull request Nov 28, 2023
@tolik0 @git-phu
✨ Source Pinterest: Update docs and spec; add missing `placement_traf…
4447fcb 
…fic_type` field to AdGroups stream (#32747)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjlai brianjlai brianjlai approved these changes

@davydov-d davydov-d davydov-d approved these changes

Assignees

@tolik0 tolik0

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/pinterest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tolik0 @davydov-d @brianjlai @octavia-squidington-iii