Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Mailchimp: Implement SegmentMembers stream #32782

Merged
merged 19 commits into from
Nov 27, 2023

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Nov 23, 2023

What

Implement new stream SegmentMembers towards achieving MLP for certification.

How

  • The SegmentMembers stream is essentially a substream of Segments (which is a substream of Lists). Each stream_slice consists of a list_id and segment_id pair for use in path.
  • Each record may contain a number of empty string values. To avoid validation issues on datetime fields when this happens, empty strings are converted to null values before each record is read.
  • Foreign key segment_id is appended to each record and declared in schema
  • The endpoint does not support filtering/sorting by timestamp, so records are filtered during parse_response call.
  • For incremental sync, each segment_id is used as a key for storing state on a per-segment basis, to ensure that records within a given segment are filtered against the latest record read in that specific segment.

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 8:56pm

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 23, 2023
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Small suggestion below.

ChristoGrab and others added 2 commits November 24, 2023 15:53
…imp/streams.py

Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>
@ChristoGrab ChristoGrab merged commit 3e69945 into dev Nov 27, 2023
25 checks passed
@ChristoGrab ChristoGrab deleted the christo/mailchimp-segmentmembers branch November 27, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mailchimp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants