-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Mailchimp: Implement SegmentMembers stream #32782
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
…/airbytehq/airbyte into christo/mailchimp-segmentmembers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Small suggestion below.
airbyte-integrations/connectors/source-mailchimp/source_mailchimp/streams.py
Outdated
Show resolved
Hide resolved
…imp/streams.py Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>
What
Implement new stream SegmentMembers towards achieving MLP for certification.
How
list_id
andsegment_id
pair for use in path.datetime
fields when this happens, empty strings are converted tonull
values before each record is read.segment_id
is appended to each record and declared in schemasegment_id
is used as a key for storing state on a per-segment basis, to ensure that records within a given segment are filtered against the latest record read in that specific segment.