-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unrevert #32806 #32847
unrevert #32806 #32847
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
eebcaef
to
5bb07fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best we could do to test is to set the --is-ci flag locally and run using modified a few times.
Thinking about it the worst case scenario here is we merge, do a prepublish test using modified on a subsequent branch, and if that goes bad, revert again.
If thats true then Im personally fine to merge and play with fire on master
Thanks for taking a look.
That's as far as I got. OK, I'll merge this tomorrow morning early. Let's see what gives! |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Reverts the revert of #32806 and fixes the following:
git_revision
when computing a diff because it's not always what we think it is (whengit_branch
is not master, it's an orphan merge commit)I have no idea how to test any of this. This is as good as I can do.