Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for markdown Tabs #32881

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

ambirdsall
Copy link
Contributor

Support for (a subset of) Docusaurus' built-in Tabs feature was added to Airbyte's in-app markdown parser in https://github.com/airbytehq/airbyte-platform-internal/pull/9806; this adds the corresponding documentation.

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 4:34pm

Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one small comment - once fixed this LGTM

docs/contributing-to-airbyte/writing-docs.md Outdated Show resolved Hide resolved
Move the explanation of , er, default `default` behavior and known edge cases around `Tabs` outside of the example tabs for better visibility.

Co-authored-by: Lake Mossman <lake@airbyte.io>
@ambirdsall
Copy link
Contributor Author

Removed the bullet list explanation of the default default behavior and markdown rendering edge cases from both the example Tabs and from the example code preceding it per @lmossman's suggestion; the preview deploy looks good to me, will merge later this morning.

@ambirdsall ambirdsall merged commit ca028bb into master Nov 30, 2023
20 checks passed
@ambirdsall ambirdsall deleted the alex/document-tabs-markdown-feature branch November 30, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants