Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Google Search Console: fix spelling mistakes in connector exceptions #32921

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

attaxia
Copy link
Contributor

@attaxia attaxia commented Nov 29, 2023

What

This change only makes textual changes to remove spelling errors.

🚨 User Impact 🚨

None

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 9:28am

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2023

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Nov 29, 2023
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@marcosmarxm
Copy link
Member

Hello @attaxia can you sign the CLA?

@attaxia
Copy link
Contributor Author

attaxia commented Nov 29, 2023

@marcosmarxm Signed

@marcosmarxm marcosmarxm changed the title Fix spelling mistakes in Google Search Console connector exceptions Source Google Search Console: fix spelling mistakes in connector exceptions Nov 29, 2023
@marcosmarxm
Copy link
Member

/approve-and-merge reason="only docstring changes in Google Search Console connector"

@octavia-approvington
Copy link
Contributor

This code is at peace with itself
imagine karate kid approving

@octavia-approvington octavia-approvington merged commit 50aaf0b into airbytehq:master Nov 29, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants