Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update customization docs #32963

Merged
merged 3 commits into from
Nov 30, 2023
Merged

update customization docs #32963

merged 3 commits into from
Nov 30, 2023

Conversation

colesnodgrass
Copy link
Member

What

  • update enterprise customization example to be factually correct
    • the $RELEASE_NAME should not be provided as a parameter, the script will read this env-var if set
    • the chart-path should not be provided as a parameter, this is hardcoded to airbyte/airbyte in the script

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 9:17pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 29, 2023
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 29, 2023 22:37
pmossman
pmossman approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@pmossman pmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming unrelated exceptions.py change is an autoformatter

@colesnodgrass
Copy link
Member Author

it is

@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Nov 30, 2023
@colesnodgrass colesnodgrass merged commit 1269a0c into master Nov 30, 2023
20 checks passed
@colesnodgrass colesnodgrass deleted the cole/abe-update-docs branch November 30, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmossman pmossman pmossman approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation connectors/source/google-search-console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colesnodgrass @pmossman @octavia-squidington-iii