Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the facebook pages doc's first heading above danger admonition #32997

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

ambirdsall
Copy link
Contributor

The prior version worked great with a dev server, but production builds would throw the following error when generating the production sidebar:

[ERROR] Error: Could not parse title from integrations/sources/facebook-pages. Make sure there's no content above the first heading!
    at /home/amb/c/airbyte/docusaurus/sidebars.js:32:15
    at Array.map (<anonymous>)
    at getFilenamesInDir (/home/amb/c/airbyte/docusaurus/sidebars.js:25:6)
    at getSourceConnectors (/home/amb/c/airbyte/docusaurus/sidebars.js:62:10)
    at Object.<anonymous> (/home/amb/c/airbyte/docusaurus/sidebars.js:278:47)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Module.require (node:internal/modules/cjs/loader:1115:19)

It was a mystery why the build was borked since I have no access to Vercel logs, but once I figured out how to reproduce the error locally, it was a very short path to fixing it.

The prior version worked great with a dev server, but production builds
would throw the following error when generating the production sidebar:

```
[ERROR] Error: Could not parse title from integrations/sources/facebook-pages. Make sure there's no content above the first heading!
    at /home/amb/c/airbyte/docusaurus/sidebars.js:32:15
    at Array.map (<anonymous>)
    at getFilenamesInDir (/home/amb/c/airbyte/docusaurus/sidebars.js:25:6)
    at getSourceConnectors (/home/amb/c/airbyte/docusaurus/sidebars.js:62:10)
    at Object.<anonymous> (/home/amb/c/airbyte/docusaurus/sidebars.js:278:47)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Module.require (node:internal/modules/cjs/loader:1115:19)
```

It was a mystery why the build was borked since I have no access to
Vercel logs, but once I figured out how to reproduce the error locally,
it was a very short path to fixing it.
Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 8:47pm

Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yep, that makes sense to me, header should be at the top 😄

@ambirdsall ambirdsall merged commit 1e001e6 into master Nov 30, 2023
21 checks passed
@ambirdsall ambirdsall deleted the alex/fix-vercel-error-with-fb-pages-docs branch November 30, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants