Source Hubspot: fix the FieldAnchor closing tag #33257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
the
area/documentation
|
@roman-yermilov-gl thanks! Looks like you can use a field anchor within the Hide In UI feature. But why are we doing so? |
timroes
approved these changes
Dec 8, 2023
erohmensing
approved these changes
Dec 8, 2023
Comment on lines
+129
to
+138
| If you set up your connections before April 15th, 2023 (on Airbyte Cloud) or before 0.8.0 (OSS) then you'll need to do some additional work to sync custom CRM objects. | ||
|
|
||
| First you need to give the connector some additional permissions: | ||
|
|
||
| <!-- env:cloud --> | ||
| - **If you are using OAuth on Airbyte Cloud** go to the Hubspot source settings page in the Airbyte UI and re-authenticate via OAuth to allow Airbyte the permissions to access custom objects. | ||
| <!-- /env:cloud --> | ||
| - **If you are using OAuth on OSS or Private App auth** go into the Hubspot UI where you created your Private App or OAuth application and add the `crm.objects.custom.read` scope to your app's scopes. See HubSpot's instructions [here](https://developers.hubspot.com/docs/api/working-with-oauth#scopes). | ||
|
|
||
| Then, go to the replication settings of your connection and click **refresh source schema** to pull in those new streams for syncing. |
There was a problem hiding this comment.
I personally would continue to hide this. Definitely makes sense to tell users that their custom objects will be available as well though!
rishabh-cldcvr
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the problem from #33042. Documnetation is broken
How
Remove autoclosing
/from<FieldAnchor />