Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destination-s3: update configs with common defaults #33264

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Dec 8, 2023

Some UX updates for destination-s3:

Now, as a note, these changes won't make it airbyte cloud because we have an old version of the connector pinned on Airbyte Cloud (reason: (incorrect filename format, do not use) Adopt java CDK version 0.4.). We'll investigate this when we revisit S3's certification next year. re: #32228 and UUID file names vs numbers.

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 7:22pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/s3 labels Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@evantahler evantahler marked this pull request as ready for review December 8, 2023 19:21
@evantahler evantahler requested a review from a team as a code owner December 8, 2023 19:21
@gisripa
Copy link
Contributor

gisripa commented Dec 8, 2023

s/resist/revisit 😄

Copy link
Contributor

@gisripa gisripa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to probably note is, this was intentionally not marked as required because for OSS users deployed on aws instances, they get that from instance profile or other mechanisms

@edgao
Copy link
Contributor

edgao commented Dec 8, 2023

these changes won't make it airbyte cloud

they won't make it to oss either - we're pinning 0.5.1 everywhere

@evantahler evantahler merged commit 7a021a0 into master Dec 8, 2023
21 of 22 checks passed
@evantahler evantahler deleted the evan/s3-dest-config branch December 8, 2023 20:01
rishabh-cldcvr pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/s3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add always_show: true to S3 Key ID and S3 Access Key
4 participants