-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
destination-s3: update configs with common defaults #33264
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
s/resist/revisit 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to probably note is, this was intentionally not marked as required because for OSS users deployed on aws instances, they get that from instance profile or other mechanisms
they won't make it to oss either - we're pinning 0.5.1 everywhere |
Some UX updates for destination-s3:
access_key_id
andsecret_access_key
should be shown on the form by default - they are very common (Closes Addalways_show: true
to S3 Key ID and S3 Access Key #33254)Now, as a note, these changes won't make it airbyte cloud because we have an old version of the connector pinned on Airbyte Cloud (reason:
(incorrect filename format, do not use) Adopt java CDK version 0.4.
). We'll investigate this when we revisit S3's certification next year. re: #32228 and UUID file names vs numbers.