Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Fix BigQuery Destination: fail when using Google Default Application Credentials #34003

Conversation

shikanime
Copy link

What

Fixes: #32477

How

Determine whether to explicitly verify the service account format as a JSON string or rely on the Google Auth library to handle the validation.

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2024

CLA assistant check
All committers have signed the CLA.

@shikanime shikanime changed the title Fix BigQuery destination fail when using Google Default Application C… Fix BigQuery destination fail when using Google Default Application Credentials Jan 8, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jan 8, 2024
Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 9:45pm

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@shikanime shikanime changed the title Fix BigQuery destination fail when using Google Default Application Credentials 📝 Fix BigQuery Destination: fail when using Google Default Application Credentials Jan 8, 2024
@shikanime shikanime force-pushed the shikanime/bigquery-destination-default-creds branch from 54dff50 to d011725 Compare January 8, 2024 16:34
@shikanime shikanime force-pushed the shikanime/bigquery-destination-default-creds branch from d011725 to 7bcc86d Compare January 9, 2024 11:26
@evantahler
Copy link
Contributor

Closing in favor of #34073

@evantahler evantahler closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Destination BigQuery: using application default GCP credentials broken
4 participants