Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snowflake-destination: upgrade cdk version to start emitting destination stats as part of state #34083

Merged
merged 2 commits into from
Jan 11, 2024
Merged

snowflake-destination: upgrade cdk version to start emitting destination stats as part of state #34083

merged 2 commits into from
Jan 11, 2024

Conversation

subodh1810
Copy link
Contributor

@subodh1810 subodh1810 commented Jan 10, 2024 •
edited
Loading

Issue: #33864

@subodh1810 subodh1810 self-assigned this Jan 10, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 8:42am

@github-actions GitHub Actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 10, 2024
@subodh1810 subodh1810 requested a review from edgao January 10, 2024 09:29
@subodh1810 subodh1810 marked this pull request as ready for review January 10, 2024 09:29
@subodh1810 subodh1810 requested a review from a team as a code owner January 10, 2024 09:29
@subodh1810 subodh1810 mentioned this pull request Jan 10, 2024
Closed
@subodh1810 subodh1810 requested a review from evantahler January 10, 2024 18:01
edgao
edgao approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: tests are passing!

(and I think I saw in slack that you ran some manual syncs? like I mentioned on the other pr - DATs are disabled on snowflake right now)

@subodh1810
Copy link
Contributor Author

@edgao Yup I did run syncs locally https://airbytehq-team.slack.com/archives/C0624HL9UTU/p1704879191541409

@subodh1810 subodh1810 merged commit 7d9f636 into master Jan 11, 2024
24 of 28 checks passed
@subodh1810 subodh1810 deleted the upgrade-snowflake-destination-stats branch January 11, 2024 17:30
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@subodh1810 @jatinyadav-cc
snowflake-destination: upgrade cdk version to start emitting destinat…
810f9f6 
…ion stats as part of state (airbytehq#34083)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@subodh1810 @jatinyadav-cc
snowflake-destination: upgrade cdk version to start emitting destinat…
f1f1969 
…ion stats as part of state (airbytehq#34083)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

@evantahler evantahler Awaiting requested review from evantahler

Assignees

@subodh1810 subodh1810

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subodh1810 @edgao @octavia-squidington-iii