DV2 TypingDedupingTest: read container stdout in real time #34173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
gisripa
reviewed
Jan 11, 2024
| ); | ||
| messageHandler.submit(() -> { | ||
| while (!destination.isFinished()) { | ||
| destination.attemptRead(); |
There was a problem hiding this comment.
I didn't see another call for attemptRead so seems safe but just a note that attemptRead isn't thread safe.
There was a problem hiding this comment.
yep it's only called from here. I'll add a comment though
gisripa
approved these changes
Jan 11, 2024
|
no need to publish cdk since T+D isn't (yet) in the cdk. No need to publish connectors since this is just test code. merging directly. |
jbfbell
pushed a commit
that referenced
this pull request
Jan 12, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discovered accidentally - if a connector container logs too much to stdout, it eventually gets blocked because the buffer fills up. Dump stdout in a background thread instead.
I could be convinced to pass the executor service / future through to the
endSyncmethod? but that seemed overkill