Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination postgres: DV2 beta implementation #34177

Merged
merged 105 commits into from
Jan 17, 2024
Merged

Destination postgres: DV2 beta implementation #34177

merged 105 commits into from
Jan 17, 2024

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jan 11, 2024 •
edited
Loading

copied from #33910, with a merge from master to hopefully fix tests. Removes the spec option from postgres, since we're not quite ready for beta release yet.

test syncs:

assuming these both run correctly overnight, that should be sufficient evidence that syncs are still functioning correctly.

edgao added 30 commits December 21, 2023 10:47
@edgao
make methods public
7ec0e4a
@edgao
allow overriding timestamptz type
b0f6035
@edgao
better?
e65e315
@edgao
move jdbc base test into db-destinations testFixtures
e9c6e34
@edgao
override annotation
6ee0add
@edgao
fixes
aade64a
@edgao
typing_deduping core code uses Sql struct
d8fde89
@edgao
update bigquery
d7949a0
@edgao
update snowflake
30f8a4d
@edgao
update redshift
cd6b03b
@edgao
autoappend semicolon
803c758
@edgao
move insert statement to base class
af0d77a
@edgao
Merge branch 'dv2_cdk_changes' into edgao/dv2_sql_refactor
f9a4193
@edgao
propagate safe_cast option to subclass
3f31078
@edgao
Merge branch 'dv2_cdk_changes' into edgao/dv2_sql_refactor
d952aab
@edgao
fix redshift sqlgenerator
d25cb85
@edgao
Merge branch 'dv2_cdk_changes' into edgao/dv2_sql_refactor
ef2ddd4
@edgao
make methods public
b21a539
@edgao
allow overriding timestamptz type
8d55bac
@edgao
better?
a37d096
@edgao
move jdbc base test into db-destinations testFixtures
0f7cf74
@edgao
override annotation
2583a70
@edgao
fixes
2e6e931
@edgao
move insert statement to base class
b4ffdba
@edgao
propagate safe_cast option to subclass
4d045ca
@edgao
fix redshift sqlgenerator
3c53c37
@edgao
Merge branch 'dv2_cdk_changes' into edgao/dv2_sql_refactor
54350e9
@edgao
fix redshift test
b0a667d
@edgao
Merge branch 'dv2_cdk_changes' into edgao/dv2_sql_refactor
df833f9
@edgao
use local cdk
9463896
@gisripa
Copy link
Contributor

gisripa commented Jan 12, 2024 •
edited
Loading

Looks good to me. Can you rebase (sorry there will be a bunch of conflicts from my dependency cleanup) and publish CDK since the tests are failing to find 0.13.0 artifact

@edgao
Copy link
Contributor Author

edgao commented Jan 12, 2024

thanks for looking! I'll do that post-long-weekend... feels irresponsible to publish artifacts from a 1k line pr right now :P

though for the record - the last "real" commit was 4084e63, where the failures are all because of the version bump check. The diff after that is basically just metadata/changelogs (plus removing the dumb change for cache bust that we were using to investigate CI).

@edgao
Merge branch 'master' into dv2/postgres_take2
a859acc 
# Conflicts:
#	airbyte-integrations/connectors/destination-bigquery/build.gradle
#	airbyte-integrations/connectors/destination-redshift/build.gradle
#	airbyte-integrations/connectors/destination-snowflake/build.gradle
#	docs/integrations/destinations/bigquery.md
#	docs/integrations/destinations/snowflake.md
@edgao edgao mentioned this pull request Jan 12, 2024
Merged
@edgao
Copy link
Contributor Author

edgao commented Jan 16, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/7544893217
✅ Successfully published Java CDK version=0.13.0!

@edgao edgao enabled auto-merge (squash) January 16, 2024 17:29
@edgao edgao disabled auto-merge January 16, 2024 21:11
@edgao
Merge branch 'master' into dv2/postgres_take2
4f7a66e 
# Conflicts:
#	airbyte-cdk/java/airbyte-cdk/README.md
#	airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties
#	airbyte-integrations/connectors/destination-redshift/build.gradle
#	docs/integrations/destinations/redshift.md
@edgao edgao force-pushed the dv2/postgres_take2 branch from c00299b to 4f7a66e Compare January 16, 2024 23:01
@edgao
Copy link
Contributor Author

edgao commented Jan 16, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk force=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/7548567245
✅ Successfully published Java CDK version=0.13.0!

@edgao
Copy link
Contributor Author

edgao commented Jan 16, 2024

republishing b/c another cdk change got merged to master

@edgao edgao enabled auto-merge (squash) January 16, 2024 23:15
@gisripa gisripa disabled auto-merge January 17, 2024 00:39
@edgao edgao enabled auto-merge (squash) January 17, 2024 16:46
@edgao edgao merged commit 0063382 into master Jan 17, 2024
25 checks passed
@edgao edgao deleted the dv2/postgres_take2 branch January 17, 2024 18:32
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@edgao @jatinyadav-cc
Destination postgres: DV2 beta implementation (airbytehq#34177)
93f7bbb
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@edgao @jatinyadav-cc
Destination postgres: DV2 beta implementation (airbytehq#34177)
f1ac559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gisripa gisripa gisripa approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit checklist-action-run connectors/destination/bigquery connectors/destination/postgres connectors/destination/postgres-strict-encrypt connectors/destination/redshift connectors/destination/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgao @gisripa @octavia-squidington-iii